Summary:

This PR removes forward declaration of loadSourceForBridge methods from the RCTRootViewFactory as it was causing an issue on old architecture, where the RedBox wouldn't popup when metro wasn't running.

As stated by @Kudo here:

the problem was coming from the implementation

react-native/packages/react-native/React/CxxBridge/RCTCxxBridge.mm

Lines 519 to 540 in 00725fa

	if ([self.delegate respondsToSelector:@selector(loadSourceForBridge:onProgress:onComplete:)]) {
	[self.delegate loadSourceForBridge:_parentBridge onProgress:onProgress onComplete:onSourceLoad];
	} else if ([self.delegate respondsToSelector:@selector(loadSourceForBridge:withBlock:)]) {
	[self.delegate loadSourceForBridge:_parentBridge withBlock:onSourceLoad];
	} else if (!self.bundleURL) {
	NSError *error = RCTErrorWithMessage(
	@"No bundle URL present.\n\nMake sure you're running a packager "
	"server or have included a .jsbundle file in your application bundle.");
	onSourceLoad(error, nil);
	} else {
	__weak RCTCxxBridge *weakSelf = self;
	[RCTJavaScriptLoader loadBundleAtURL:self.bundleURL
	onProgress:onProgress
	onComplete:^(NSError *error, RCTSource *source) {
	if (error) {
	[weakSelf handleError:error];
	return;
	}
	onSourceLoad(error, source);
	}];
	}
	}

we should dynamically override loadSourceForBridge:onProgress:onComplete: and loadSourceForBridge:withBlock: in RCTRootViewFactory only when AppDelegate override it. one way to achieve this might be tricky that we may need to override respondsToSelector:.

otherwise, we could just skip the loadSourceForBridge:onProgress:onComplete: and loadSourceForBridge:withBlock: support.

There is no straight forward solution to implement this without some hacks so I'm removing this forward block for now.

Changelog:

[IOS] [FIXED] - remove loadSourceForBridge in RCTRootViewFactory

Test Plan:

CI Green